Ignore expression when asserting that sorts are equal#1498
Conversation
njr-11
left a comment
njr-11
left a comment
There was a problem hiding this comment.
Since string-based sorts don't get an expression ... but the ones created from attributes do ... let's just not expect them to match ?
It looks like you are recommending to have the TCK overlook the change in behavior by altering the test case. Even if the test case is made to conveniently not notice, Data 1.1 would still be introducing a behavior change vs Data 1.0. We cannot do that.
|
I mean ... data/api/src/main/java/jakarta/data/expression/TextExpression.java Lines 56 to 58 in 60413f5 data/api/src/main/java/jakarta/data/Sort.java Lines 393 to 395 in f37ba8e it's Data itself that broke it ? |
Yes, and I was the one who broke it due to a mistake in one of my changes. I have a correction to what I broke in #1496 which has not been merged yet. We should be fixing the break rather than altering the TCK to overlook it. |
|
ah 🙂 so you already were working on a fix! Let's close this one then. |
I did already test #1496 by verifying the TCK passes again, but you are certainly welcome to test it with Hibernate. The only reason the fix wasn't merged is that it still needs a review by a Jakarta Data committer. |
2 participants
Since string-based sorts don't get an expression ... but the ones created from attributes do ... let's just not expect them to match ?
cc: @njr-11